Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish basic style analyzer rules #3759

Merged
merged 9 commits into from
Aug 30, 2023

Conversation

Morilli
Copy link
Collaborator

@Morilli Morilli commented Aug 25, 2023

This establishes some basic style rules that should be displayed in the IDE and (some should) surface as build warnings when RunAnalyzersDuringBuild is enabled. Ideally all of these should be agreed upon and followed in future commits.

Should perhaps be applied before #3754 to establish some ground rules. I'd also appreciate feedback on the severity and rules themselves; I've tried to enable rules and choose their severity sensibly but I'm open for differing opinions.

Check if completed:

.editorconfig Outdated Show resolved Hide resolved
@Morilli
Copy link
Collaborator Author

Morilli commented Aug 30, 2023

Alright will just get this in then, can always tweak later.

@Morilli Morilli merged commit 362269c into TASEmulators:master Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants